Fourth and final R7b batch-2 port, checklist-first recipe (docs/design/php-kernel-port-checklist.md). Grammar bump first, validated standalone with the diff ENUMERATED + CLASSIFIED (unlike rust/ruby the php bump is NOT graph-neutral): tree-sitter-php ^0.22 (tree-sitter-wasms, 2023) → v0.24.2, the full HTML-interleaving `php` variant (the walker calls LANGUAGE_PHP, never PHP_ONLY) — crate pinned =0.24.2, wasm built from tag 5b5627f's checked-in php/src/parser.c + scanner.c + shared common/scanner.h (all sha-matched against the crates.io tarball, ABI 14→15). Old-vs-new full-init diffs decompose completely into: (1) the anonymous_class wrapper shape (anon-class nodes/methods re-shape — 2,532 rows), (2) grouped nested-clause skip (absent in the gate repos, fixture-pinned), (3) 32 formerly-erroring files parsing clean (monolog Level.php, symfony Request/Response with 8.4 property hooks), (4) a survey-missed category found at gate time: the 8.4 parenthesis-free `new X()->m()` chaining misparse fix (86 garbage instantiates refs disappear, precision-positive), plus resolution RIPPLE proven mechanically (every remaining ref-table flip pairs 1:1 with a resolved edge on the opposite side; node rows byte-stable outside 1/3/4). Walker (java.rs chassis + the php specifics) preserves bug-for-bug: the visitNode hook (const_declaration at ANY scope → bare `constant` nodes, values never walked; trait-use → implements refs WITH filePath via the ruby port's REF_FLAG_FILE_PATH wire slot), FIRST-namespace whole-file scoping (braced namespaces scope nothing; namespaced files DROP top-level const value-ref targets), the import trio (single/aliased/grouped incl. the nested-clause skip, include/require static-literal-only, `Foo\Bar::Baz` use refs), the call-encoding zoo (DOT-joined scoped calls, `this->prop.m` #1251 encoding, `Cls::factory().m` fluent with inner args dropped, nullsafe `?->` emitting nothing, unsuppressed literal receivers), interface multi-extends first-base-only drop, anon-class methods as file-level functions (top) or vanishing (in-body), property type-hints emitting no field refs, the final-modifier-as-type signature quirk, HOF-gated string callables (skipGate) + array callables, and the `name`-node value-ref reader. Gates: sweeps 0-diff monolog 217/217, laravel-framework 3007/3008, symfony 10726/10737 (13,950 files byte-parity; 12 deferrals = exactly the predicted genuinely-broken fixtures, ≈0–0.1%); full-init dumps byte-identical ×3 (16.1k/354.2k/702.8k lines); kernel-php-parity suite (torture + drupal .module + leading-HTML fixtures, CRLF variants, wire-flag pin, defer) + php grammar-parity row; full suite 2,622 green ×2 under CODEGRAPH_KERNEL_EXPECT=1. DEFAULT_ROUTED += php (13 languages). Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
205 lines
8.6 KiB
TypeScript
205 lines
8.6 KiB
TypeScript
/**
|
|
* Native-kernel scaffold tests (R1, docs/design/rust-kernel-migration-plan.md).
|
|
*
|
|
* Covers the wire contract, decoder, routing policy, kill switch, and
|
|
* per-file fallback. These are SCAFFOLD tests — behavioral parity with the
|
|
* wasm extractors is R3's equivalence gate, not asserted here.
|
|
*
|
|
* The kernel binary is optional: without a staged .node
|
|
* (scripts/build-kernel.sh) the suite skips. CI that builds the kernel sets
|
|
* CODEGRAPH_KERNEL_EXPECT=1, which turns "missing binary" into a FAILURE so
|
|
* the gate can't silently pass by not building the kernel.
|
|
*/
|
|
|
|
import { describe, it, expect, beforeAll, beforeEach, afterEach } from 'vitest';
|
|
import * as fs from 'fs';
|
|
import * as path from 'path';
|
|
import { NODE_KINDS, EDGE_KINDS } from '../src/types';
|
|
import { generateNodeId } from '../src/extraction/tree-sitter-helpers';
|
|
import { getKernel, tryKernelExtract, kernelRoutes, resetKernelForTests } from '../src/extraction/kernel';
|
|
import { extractFromSource } from '../src/extraction';
|
|
import { initGrammars, loadGrammarsForLanguages } from '../src/extraction/grammars';
|
|
|
|
const KERNEL_PATH = path.join(
|
|
__dirname,
|
|
'..',
|
|
'codegraph-kernel',
|
|
'prebuilds',
|
|
`${process.platform}-${process.arch}`,
|
|
'codegraph-kernel.node'
|
|
);
|
|
const kernelBuilt = fs.existsSync(KERNEL_PATH);
|
|
const expectKernel = process.env.CODEGRAPH_KERNEL_EXPECT === '1';
|
|
|
|
const FIXTURE = [
|
|
'export class MathHelper {',
|
|
' calculateTotal(a: number): number { return helper(a); }',
|
|
'}',
|
|
'function helper(x: number): number { return x * 2; }',
|
|
'helper(3);',
|
|
'',
|
|
].join('\n');
|
|
|
|
const ENV_KEYS = ['CODEGRAPH_KERNEL', 'CODEGRAPH_KERNEL_LANGS', 'CODEGRAPH_KERNEL_PATH'] as const;
|
|
let savedEnv: Record<string, string | undefined>;
|
|
|
|
beforeEach(() => {
|
|
savedEnv = Object.fromEntries(ENV_KEYS.map((k) => [k, process.env[k]]));
|
|
for (const k of ENV_KEYS) delete process.env[k];
|
|
resetKernelForTests();
|
|
});
|
|
|
|
afterEach(() => {
|
|
for (const k of ENV_KEYS) {
|
|
if (savedEnv[k] === undefined) delete process.env[k];
|
|
else process.env[k] = savedEnv[k];
|
|
}
|
|
resetKernelForTests();
|
|
});
|
|
|
|
it.runIf(expectKernel)('kernel binary must exist when CODEGRAPH_KERNEL_EXPECT=1', () => {
|
|
expect(kernelBuilt, `expected kernel at ${KERNEL_PATH} — run scripts/build-kernel.sh`).toBe(true);
|
|
});
|
|
|
|
describe.skipIf(!kernelBuilt)('kernel scaffold', () => {
|
|
it('loads and its kind tables match src/types.ts exactly', () => {
|
|
const kernel = getKernel();
|
|
expect(kernel).not.toBeNull();
|
|
const info = kernel!.contractInfo();
|
|
expect(info.nodeKinds).toEqual([...NODE_KINDS]);
|
|
expect(info.edgeKinds).toEqual([...EDGE_KINDS]);
|
|
expect(info.languages).toContain('typescript');
|
|
expect(info.languages).toContain('javascript');
|
|
});
|
|
|
|
it('TS/JS family + Java + Python + Go route to the kernel by default; others stay wasm', () => {
|
|
for (const lang of ['typescript', 'tsx', 'javascript', 'jsx', 'java', 'python', 'go', 'ruby', 'php'] as const) {
|
|
expect(kernelRoutes(lang), lang).toBe(true);
|
|
}
|
|
expect(kernelRoutes('kotlin')).toBe(false);
|
|
expect(tryKernelExtract('src/a.kt', 'fun f() {}\n', 'kotlin')).toBeNull();
|
|
// CODEGRAPH_KERNEL_LANGS REPLACES the default set when present.
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'tsx';
|
|
expect(kernelRoutes('typescript')).toBe(false);
|
|
expect(kernelRoutes('tsx')).toBe(true);
|
|
});
|
|
|
|
describe('with typescript routed (CODEGRAPH_KERNEL_LANGS)', () => {
|
|
beforeEach(() => {
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'typescript';
|
|
});
|
|
|
|
it('decodes nodes, contains edges, and calls refs from the buffers', () => {
|
|
const result = tryKernelExtract('src/utils.ts', FIXTURE, 'typescript');
|
|
expect(result).not.toBeNull();
|
|
const { nodes, edges, unresolvedReferences, errors } = result!;
|
|
expect(errors).toEqual([]);
|
|
|
|
const byKind = (kind: string) => nodes.filter((n) => n.kind === kind);
|
|
expect(byKind('file')).toHaveLength(1);
|
|
expect(byKind('class').map((n) => n.name)).toEqual(['MathHelper']);
|
|
expect(byKind('method').map((n) => n.qualifiedName)).toEqual(['MathHelper::calculateTotal']);
|
|
expect(byKind('function').map((n) => n.name)).toEqual(['helper']);
|
|
|
|
const file = byKind('file')[0]!;
|
|
expect(file.id).toBe('file:src/utils.ts');
|
|
expect(file.qualifiedName).toBe('src/utils.ts');
|
|
expect(file.endLine).toBe(FIXTURE.split('\n').length);
|
|
expect(file.isExported).toBe(false);
|
|
|
|
// Every node carries the decode-call constants.
|
|
for (const n of nodes) {
|
|
expect(n.filePath).toBe('src/utils.ts');
|
|
expect(n.language).toBe('typescript');
|
|
expect(n.updatedAt).toBeGreaterThan(0);
|
|
}
|
|
|
|
// contains: file→class, class→method, file→function.
|
|
const contains = edges.filter((e) => e.kind === 'contains');
|
|
const cls = byKind('class')[0]!;
|
|
const method = byKind('method')[0]!;
|
|
const fn = byKind('function')[0]!;
|
|
expect(contains).toContainEqual({ source: file.id, target: cls.id, kind: 'contains' });
|
|
expect(contains).toContainEqual({ source: cls.id, target: method.id, kind: 'contains' });
|
|
expect(contains).toContainEqual({ source: file.id, target: fn.id, kind: 'contains' });
|
|
|
|
// calls refs attach to the innermost enclosing symbol (method for the
|
|
// in-body call, file node for the top-level call).
|
|
const calls = unresolvedReferences.filter((r) => r.referenceKind === 'calls');
|
|
expect(calls.map((r) => [r.fromNodeId, r.referenceName])).toEqual([
|
|
[method.id, 'helper'],
|
|
[file.id, 'helper'],
|
|
]);
|
|
for (const r of calls) {
|
|
// No denormalized filePath/language at the extraction seam — the wasm
|
|
// extractors leave them unset (the store fills them, `?? filePath`),
|
|
// and the kernel matches that exactly (see decode.ts).
|
|
expect(r.filePath).toBeUndefined();
|
|
expect(r.language).toBeUndefined();
|
|
expect(r.line).toBeGreaterThan(0);
|
|
}
|
|
});
|
|
|
|
it('kernel node ids are byte-identical to generateNodeId', () => {
|
|
const result = tryKernelExtract('src/utils.ts', FIXTURE, 'typescript')!;
|
|
for (const n of result.nodes) {
|
|
if (n.kind === 'file') continue;
|
|
expect(n.id).toBe(generateNodeId('src/utils.ts', n.kind, n.name, n.startLine));
|
|
}
|
|
});
|
|
|
|
it('CODEGRAPH_KERNEL=0 kill switch disables routing', () => {
|
|
process.env.CODEGRAPH_KERNEL = '0';
|
|
expect(kernelRoutes('typescript')).toBe(false);
|
|
expect(tryKernelExtract('src/a.ts', FIXTURE, 'typescript')).toBeNull();
|
|
});
|
|
|
|
it('languages outside the route stay on the wasm path', () => {
|
|
expect(kernelRoutes('javascript')).toBe(false);
|
|
expect(tryKernelExtract('src/a.js', 'function f() {}', 'javascript')).toBeNull();
|
|
});
|
|
|
|
it('tsx routes with its own entry and returns a graph', () => {
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'typescript,tsx';
|
|
const result = tryKernelExtract(
|
|
'src/App.tsx',
|
|
'export function App() { return render(); }\n',
|
|
'tsx'
|
|
);
|
|
expect(result).not.toBeNull();
|
|
expect(result!.nodes.some((n) => n.kind === 'function' && n.name === 'App')).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe('extractFromSource seam', () => {
|
|
beforeAll(async () => {
|
|
await initGrammars();
|
|
await loadGrammarsForLanguages(['typescript']);
|
|
});
|
|
|
|
it('kill switch routes through the wasm extractor unchanged', () => {
|
|
process.env.CODEGRAPH_KERNEL = '0';
|
|
const result = extractFromSource('src/a.ts', 'export const f = () => 1;\n', 'typescript');
|
|
expect(result.nodes.some((n) => n.kind === 'function' && n.name === 'f')).toBe(true);
|
|
delete process.env.CODEGRAPH_KERNEL;
|
|
// Default-routed path produces the same node (R2 parity).
|
|
const viaKernel = extractFromSource('src/a.ts', 'export const f = () => 1;\n', 'typescript');
|
|
expect(viaKernel.nodes.some((n) => n.kind === 'function' && n.name === 'f')).toBe(true);
|
|
});
|
|
|
|
it('routed language takes the kernel and falls back per file on kernel absence', () => {
|
|
process.env.CODEGRAPH_KERNEL_LANGS = 'typescript';
|
|
const viaKernel = extractFromSource('src/utils.ts', FIXTURE, 'typescript');
|
|
expect(viaKernel.nodes.map((n) => n.kind)).toContain('method');
|
|
|
|
// Point the loader at a nonexistent binary: routing is requested but the
|
|
// kernel can't load, so the SAME call must fall back to wasm, not fail.
|
|
process.env.CODEGRAPH_KERNEL_PATH = path.join(__dirname, 'nope', 'missing.node');
|
|
process.env.CODEGRAPH_KERNEL = '0'; // and belt-and-braces the kill switch
|
|
resetKernelForTests();
|
|
const viaWasm = extractFromSource('src/utils.ts', FIXTURE, 'typescript');
|
|
expect(viaWasm.nodes.some((n) => n.kind === 'class' && n.name === 'MathHelper')).toBe(true);
|
|
});
|
|
});
|
|
});
|