Files
codegraph/__tests__/daemon-registry.test.ts
T
81e1f4a92f fix: harden daemon and large-index recovery paths (#1562)
* fix: harden indexing recovery and daemon liveness

* test: cover daemon and recovery review gaps

* test: pin that a failure marker never blocks a later successful parse (#1557 retry-discard guard)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: danusha2345 <ewidusoc498@gmail.com>
Co-authored-by: Colby McHenry <me@colbymchenry.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-20 12:53:49 -05:00

159 lines
5.8 KiB
TypeScript

import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import { spawn } from 'child_process';
import * as fs from 'fs';
import * as net from 'net';
import * as os from 'os';
import * as path from 'path';
import {
getRegistryDir,
isProcessAlive,
registerDaemon,
deregisterDaemon,
listDaemons,
listVerifiedDaemons,
stopDaemonAt,
type DaemonRecord,
} from '../src/mcp/daemon-registry';
import { encodeLockInfo, getDaemonPidPath } from '../src/mcp/daemon-paths';
/** A pid that's guaranteed dead: spawn a trivial process, let it exit, reap it. */
async function deadPid(): Promise<number> {
const child = spawn(process.execPath, ['-e', 'process.exit(0)']);
const pid = child.pid!;
await new Promise<void>((r) => child.on('exit', () => r()));
await new Promise((r) => setTimeout(r, 50)); // let the OS reap it
return pid;
}
function rec(root: string, pid: number, startedAt = Date.now()): DaemonRecord {
return { root, pid, version: '1.0.0', socketPath: `${root}/.codegraph/daemon.sock`, startedAt };
}
describe('daemon-registry', () => {
let tmpHome: string;
let prevHome: string | undefined;
let prevUserProfile: string | undefined;
beforeEach(() => {
tmpHome = fs.mkdtempSync(path.join(os.tmpdir(), 'cg-reg-home-'));
prevHome = process.env.HOME;
prevUserProfile = process.env.USERPROFILE;
process.env.HOME = tmpHome; // os.homedir() honors HOME (POSIX) ...
process.env.USERPROFILE = tmpHome; // ... and USERPROFILE (Windows)
// Sanity: the registry must resolve under our temp home, or the test would
// pollute the real ~/.codegraph.
expect(getRegistryDir().startsWith(tmpHome)).toBe(true);
});
afterEach(() => {
if (prevHome === undefined) delete process.env.HOME; else process.env.HOME = prevHome;
if (prevUserProfile === undefined) delete process.env.USERPROFILE; else process.env.USERPROFILE = prevUserProfile;
try { fs.rmSync(tmpHome, { recursive: true, force: true }); } catch { /* ignore */ }
});
describe('isProcessAlive', () => {
it('is true for our own process and false for junk/dead pids', async () => {
expect(isProcessAlive(process.pid)).toBe(true);
expect(isProcessAlive(0)).toBe(false);
expect(isProcessAlive(-1)).toBe(false);
expect(isProcessAlive(NaN)).toBe(false);
expect(isProcessAlive(await deadPid())).toBe(false);
});
});
it('listDaemons returns [] when nothing is registered (no dir yet)', () => {
expect(listDaemons()).toEqual([]);
});
it('register → list shows a live daemon; deregister removes it', () => {
registerDaemon(rec('/proj/a', process.pid));
const live = listDaemons();
expect(live).toHaveLength(1);
expect(live[0].root).toBe('/proj/a');
expect(live[0].pid).toBe(process.pid);
deregisterDaemon('/proj/a');
expect(listDaemons()).toEqual([]);
});
it('prunes records whose process is dead', async () => {
const dead = await deadPid();
registerDaemon(rec('/proj/dead', dead));
registerDaemon(rec('/proj/live', process.pid));
const live = listDaemons();
expect(live).toHaveLength(1);
expect(live[0].root).toBe('/proj/live');
// The dead record's file was deleted as a side effect.
const remaining = fs.readdirSync(getRegistryDir()).filter((f) => f.endsWith('.json'));
expect(remaining).toHaveLength(1);
});
it('peeking with prune:false leaves dead records on disk', async () => {
const dead = await deadPid();
registerDaemon(rec('/proj/dead', dead));
expect(listDaemons({ prune: false })).toEqual([]); // dead is filtered from results
// ...but the file survives for the caller to inspect.
expect(fs.readdirSync(getRegistryDir()).filter((f) => f.endsWith('.json'))).toHaveLength(1);
});
it('lists multiple live daemons newest-first', () => {
registerDaemon(rec('/proj/old', process.pid, 1000));
registerDaemon(rec('/proj/new', process.pid, 2000));
const live = listDaemons();
expect(live.map((d) => d.root)).toEqual(['/proj/new', '/proj/old']);
});
it('keeps a registry entry whose socket hello matches its PID and version', async () => {
const root = fs.mkdtempSync(path.join(tmpHome, 'verified-'));
const socketPath = process.platform === 'win32'
? `\\\\.\\pipe\\cg-reg-${process.pid}-${Date.now()}`
: path.join(tmpHome, 'verified.sock');
const server = net.createServer((socket) => {
socket.end(JSON.stringify({
protocol: 1,
pid: process.pid,
codegraph: '1.5.0',
socketPath,
}) + '\n');
});
await new Promise<void>((resolve, reject) => {
server.once('error', reject);
server.listen(socketPath, resolve);
});
try {
registerDaemon({ root, pid: process.pid, version: '1.5.0', socketPath, startedAt: 1 });
expect((await listVerifiedDaemons()).map((d) => d.root)).toEqual([root]);
} finally {
await new Promise<void>((resolve) => server.close(() => resolve()));
}
});
it('never signals a reused live PID when no matching daemon answers (#1553)', async () => {
const root = fs.mkdtempSync(path.join(tmpHome, 'project-'));
const pidPath = getDaemonPidPath(root);
fs.mkdirSync(path.dirname(pidPath), { recursive: true });
fs.writeFileSync(pidPath, encodeLockInfo({
pid: process.pid,
version: '1.5.0',
socketPath: path.join(root, '.codegraph', 'missing.sock'),
startedAt: Date.now() - 60_000,
}));
registerDaemon({
root,
pid: process.pid,
version: '1.5.0',
socketPath: path.join(root, '.codegraph', 'missing.sock'),
startedAt: Date.now() - 60_000,
});
expect(await listVerifiedDaemons()).toEqual([]);
const result = await stopDaemonAt(root);
expect(result).toMatchObject({ pid: process.pid, outcome: 'not-running' });
expect(isProcessAlive(process.pid)).toBe(true);
expect(fs.existsSync(pidPath)).toBe(false);
});
});