SRIKANTH AandGitHub
7340892290
Replace the 7 unbounded ReferenceResolver Map caches with a bounded LRU (env-tunable via CODEGRAPH_RESOLVER_CACHE_SIZE) so memory stays flat on large codebases, and add length caps on MCP tool string inputs (query/task/symbol + projectPath/path/pattern) to prevent oversized-payload DoS. Includes LRU, MCP-input-limit, and full-pipeline integration tests. Closes #213
63 lines
1.8 KiB
TypeScript
63 lines
1.8 KiB
TypeScript
/**
|
|
* Simple LRU cache backed by JavaScript's insertion-ordered Map.
|
|
*
|
|
* Used by ReferenceResolver to bound the per-resolver caches that
|
|
* previously grew without limit and OOM'd on large codebases (20k+
|
|
* files). Each cache is sized independently — see `index.ts` for
|
|
* the chosen limits per cache type.
|
|
*
|
|
* Eviction is plain LRU: on `set`, if the cache is full, the
|
|
* least-recently-used entry (the first one in iteration order) is
|
|
* evicted. Touching via `get` moves the entry to the most-recently-used
|
|
* position so hot keys survive eviction passes.
|
|
*/
|
|
export class LRUCache<K, V> {
|
|
private readonly max: number;
|
|
private readonly store = new Map<K, V>();
|
|
|
|
constructor(max: number) {
|
|
if (!Number.isFinite(max) || max <= 0) {
|
|
throw new Error(`LRUCache max must be a positive finite number, got ${max}`);
|
|
}
|
|
this.max = Math.floor(max);
|
|
}
|
|
|
|
get size(): number {
|
|
return this.store.size;
|
|
}
|
|
|
|
get(key: K): V | undefined {
|
|
const value = this.store.get(key);
|
|
if (value === undefined) {
|
|
// Distinguish "missing" from "stored undefined" by checking has().
|
|
// We don't store undefined in practice, but be defensive.
|
|
return this.store.has(key) ? value : undefined;
|
|
}
|
|
// Refresh recency by re-inserting.
|
|
this.store.delete(key);
|
|
this.store.set(key, value);
|
|
return value;
|
|
}
|
|
|
|
has(key: K): boolean {
|
|
return this.store.has(key);
|
|
}
|
|
|
|
set(key: K, value: V): void {
|
|
if (this.store.has(key)) {
|
|
this.store.delete(key);
|
|
} else if (this.store.size >= this.max) {
|
|
// Evict the oldest entry — first key in iteration order.
|
|
const oldest = this.store.keys().next().value;
|
|
if (oldest !== undefined) {
|
|
this.store.delete(oldest);
|
|
}
|
|
}
|
|
this.store.set(key, value);
|
|
}
|
|
|
|
clear(): void {
|
|
this.store.clear();
|
|
}
|
|
}
|