Fixes #1581. ## What was wrong `codegraph init` / `codegraph index` died with `Segmentation fault` — the whole CLI process, not a parse worker — on a C/C++ file with very deep brace nesting (llvm's `clang/test/Parser/parser_overflow.c`, 16,384 nested `{`). The reporter's diagnosis is exactly right: tree-sitter's parser is iterative, so the file parses fine, and then the native kernel's **recursive walker** (`visit_node` → `visit_for_calls_and_structure` → …, one frame per AST level) overflowed the thread's stack. A native overflow can't be caught the way a wasm abort can, and a parse worker is a thread of the `codegraph` process, so the SIGSEGV took the entire indexer down — no message, no per-file fallback, no partial index. Two things made "just give the worker a bigger stack" the wrong fix: - it only moves the cliff — reproduced here: the reporter's 16,384-deep file kills a default 4 MiB worker (rc=132 on macOS / 139 on Linux), and a 100k-deep file kills the 8 MiB **main** thread too; - the walkers are shared by every kernel-routed language (20 of them), and each has several recursion points with different frame sizes, so no single stack size is a provable bound. Meanwhile the wasm path already handles this shape gracefully: its JS walker catches its own `RangeError` per file and stores a partial result with a `parse_error`. The kernel just needed a way to get there instead of dying. ## What this does **The kernel guards its own recursion against the calling thread's real stack bounds and defers a too-deep file to wasm** — the same `defer:` routing signal it already uses for files with parse errors, which `src/extraction/kernel/index.ts` treats as "take the wasm path for this file", silently. - `codegraph-kernel/src/stack.rs`: per-thread stack bounds from the OS, computed once per thread and cached — glibc/musl `pthread_getattr_np` + `pthread_attr_getstack`, macOS `pthread_get_stackaddr_np` + `pthread_get_stacksize_np`, Win32 `GetCurrentThreadStackLimits` (a hand-declared `kernel32` extern; no `windows-sys`). `exhausted()` is one thread-local load and one compare: true once the stack pointer is within a 256 KiB red zone of the limit, and it latches a flag. Where the OS can't report bounds it falls back to a fixed 1 MiB descent budget measured from the entry stack pointer — safe on anything from Node's 4 MiB worker default up. So the guard is exact on the 4 MiB worker, the 8 MiB main thread, and any `resourceLimits.stackSizeMb` alike. - `stack_guard!()` (defined in `lib.rs`) is the first statement of every recursive walker function — all **150** self-recursive or on-cycle functions across the 15 walker modules, found by script (every cycle in the call graph, not just direct self-calls). It returns `Default::default()` (`()`, `false`, `None`, `""`) so an exhausted walk simply stops descending; a hook returning `false` sends its caller down the generic child walk, whose own guard returns at once. - `extract_file` runs the whole walk under `stack::run_guarded`: if the flag is set afterwards the (truncated) result is discarded and replaced by `defer: nesting too deep for the native walker — wasm recovery handles it`. - `parse-pool.ts`: a comment at `new Worker(scriptPath)` records why there is deliberately no `resourceLimits.stackSizeMb` bump. - No new crates beyond `libc` as a direct unix dependency (already in `Cargo.lock` transitively). No wire/ABI change. Net effect for the reporter's repo: `deep.c` goes to the wasm path, lands as `function foo` plus a recorded parse warning, and the other 31,607 files index normally. `CODEGRAPH_KERNEL=0` and the `exclude` workaround are no longer needed. ## Tests **Rust unit tests** (`cargo test`, 21 passed — 7 new in `stack.rs`): the walkers for C, C++, Rust, TypeScript and Python are driven on a **1 MiB** thread (a quarter of Node's worker default) with 30k-deep nesting and must return `defer:` instead of crashing; shallow files are untouched; the latch resets between runs; the OS bounds are sane on the main thread and describe a small thread's own stack. **`__tests__/kernel-deep-nesting.test.ts`** (new, 8 tests — skips without a staged `.node`, fails under `CODEGRAPH_KERNEL_EXPECT=1` if the kernel is missing, like the other kernel suites): - every default-routed language (all 20) survives a 60k-deep expression on the main thread — clean result or the wasm fallback's partial result, never a crash; - the reporter's exact 16,384-brace C file is indexed (partial) on the main thread; - 200-deep expressions in every language still take the kernel path clean (the guard never trips on normal code); - inside a **default-sized 4 MiB `worker_threads` Worker** through `dist/`: the reporter's `deep.c` and a 60k-deep expression in every language come back `deferred` with exit 0, and a normal file still extracts natively; - end-to-end through the built CLI: `codegraph init` on a repo holding `deep.c` + `ok.c` exits 0 and records both files, with both functions. **Existing kernel suites**: all 15 (`kernel-*-parity`, `kernel-scaffold`, `kernel-retry-materialize`, `kernel-grammar-parity`) pass unchanged, 147 tests — the guard never fires on the parity fixtures. **Reporter's probes** (`one.js` from the issue, default 4 MiB worker, this build): `deep.c` → `deferred`, exitCode=0 (was rc=132/139); `deep100k.c` → `deferred`, exitCode=0. Main thread: `deep.c` / `deep100k.c` → wasm partial with `Parse error: Maximum call stack size exceeded`; a 6,000-term binary expression and a 3,000-branch `else if` chain stay on the kernel path with clean results. **Perf** (same `dist/`, only the `.node` swapped via `CODEGRAPH_KERNEL_PATH`; interleaved main/new ×3, `codegraph init`, macOS arm64): | repo | main (median) | guarded (median) | nodes / edges | |---|---|---|---| | express (141 files) | 0.60 s (0.58–0.65) | 0.61 s (0.58–0.61) | 1,084 / identical | | redis (786 C/H files) | 4.44 s (4.39–4.66) | 4.49 s (4.41–4.70) | 19,942 / 76,446 identical | Within run-to-run noise, as expected for one TLS load + compare per recursion entry. **Linux (Docker, `node:22-bookworm`, kernel built in-container, `docker run --rm --init`)** — the reporter's platform and the glibc `pthread_getattr_np` bounds path: ``` === platform === Linux efe3cc86947b 6.12.54-linuxkit #1 SMP Tue Nov 4 21:21:47 UTC 2025 aarch64 GNU/Linux v22.22.3 -rwxr-xr-x 1 root root 35332288 Aug 22 18:02 codegraph-kernel/prebuilds/linux-arm64/codegraph-kernel.node === reporter repro (issue #1581): 16,384-brace deep.c, codegraph init === │ └ Done init exit code: 0 file: deep.c file: deep100k.c file: ok.c function: add function: bar function: foo === worker probe: kernel raw extract in a default 4 MiB worker === deep.c: deferred deep.c: worker exitCode=0 deep100k.c: deferred deep100k.c: worker exitCode=0 ok.c: kernel nodes=2 ok.c: worker exitCode=0 === cargo test stack:: (glibc pthread_getattr_np bounds path) === test stack::tests::os_bounds_are_sane_on_this_platform ... ok test stack::tests::small_stack_reports_its_own_bounds ... ok test stack::tests::normal_files_are_untouched_by_the_guard ... ok test stack::tests::deep_braces_c_defer_instead_of_crashing ... ok test stack::tests::latch_resets_between_runs ... ok test stack::tests::deep_parens_cpp_rust_ts_python_defer_instead_of_crashing ... ok test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 15 filtered out; finished in 0.23s === vitest: kernel-deep-nesting + kernel-scaffold === ✓ __tests__/kernel-scaffold.test.ts (10 tests) 30ms ✓ __tests__/kernel-deep-nesting.test.ts (8 tests) 36989ms Test Files 2 passed (2) Tests 18 passed (18) ``` (The pre-fix crash was reproduced on macOS — rc=132 in a default worker, rc=139 on the main thread at 100k depth — not re-run inside this container; the reporter's Linux x86_64 trace is the SIGSEGV form of the same overflow.) **Windows (Parallels ARM64 VM, MSVC 14.44, `cargo 1.97`, kernel built on the VM, `GetCurrentThreadStackLimits` path)**: ``` head: cbf8485 fix(kernel): guard the native walkers against stack overflow and defer deep files to wasm (#1581) === cargo build --release (win32-arm64) === Finished `release` profile [optimized] target(s) in 2m 04s staged: 35086848 bytes === cargo test (stack guard unit tests) === test stack::tests::normal_files_are_untouched_by_the_guard ... ok test stack::tests::os_bounds_are_sane_on_this_platform ... ok test stack::tests::small_stack_reports_its_own_bounds ... ok test stack::tests::deep_braces_c_defer_instead_of_crashing ... ok test stack::tests::latch_resets_between_runs ... ok test stack::tests::deep_parens_cpp_rust_ts_python_defer_instead_of_crashing ... ok test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 15 filtered out; finished in 0.49s === reporter repro: codegraph init on a 16,384-brace deep.c === └ Done init exit code: 0 === vitest: deep-nesting + scaffold (CODEGRAPH_KERNEL_EXPECT=1) === ✓ __tests__/kernel-scaffold.test.ts (10 tests) 55ms ✓ __tests__/kernel-deep-nesting.test.ts (8 tests) 67239ms ✓ every default-routed language survives a 60k-deep expression on the main thread 52801ms ✓ inside a default-sized (4 MiB) parse worker, through dist/ > defers a 60k-deep expression in every default-routed language 13050ms ✓ end-to-end: codegraph init on a repo holding the deep file > exits 0 and records deep.c alongside the normal files 936ms Test Files 2 passed (2) Tests 18 passed (18) ``` (The end-to-end test is what reads the Windows index back through `node:sqlite` — `files` = `deep.c`, `ok.c`; functions `add`, `foo`.) Full `npm test` on this branch (macOS arm64, kernel staged): **190 files passed, 3,185 tests passed, 10 skipped, 0 failed.** Clippy note: `cargo clippy` on the current toolchain (1.92) reports 18 pre-existing lints (`manual_contains`, `unnecessary_to_owned`, …) in walker code this PR only touched by inserting guard lines; none are in `stack.rs`/`lib.rs`. Left alone to keep the diff reviewable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01LxZj6W6Y1SHXwvpT3uwJpK
264 lines
9.2 KiB
Rust
264 lines
9.2 KiB
Rust
//! codegraph-kernel — native extraction kernel (napi-rs).
|
|
//!
|
|
//! Replaces ONLY the parse+extract walk inside the parse workers, behind the
|
|
//! existing `ExtractionResult` contract. Input `(filePath, content, language)`
|
|
//! per file; output flat typed buffers — one boundary crossing per file.
|
|
//! Everything downstream (resolution, synthesis, frameworks, MCP) is
|
|
//! untouched and consumes the decoded result exactly as before.
|
|
//!
|
|
//! Calls are synchronous by design: the existing `ParseWorkerPool` workers
|
|
//! already parallelize per-file, so each worker thread drives its own kernel
|
|
//! call (do NOT rebuild the pool on the Rust side — see the migration plan §3).
|
|
//!
|
|
//! Per-language extraction lives in a dedicated walker module (tsjs/ for
|
|
//! typescript/tsx/javascript/jsx) that mirrors the TS extractor for behavioral
|
|
//! parity — verified by scripts/kernel-parity.mjs and the §5 gate.
|
|
|
|
#![deny(clippy::all)]
|
|
|
|
/// First statement of every recursive walker function (see stack.rs, #1581):
|
|
/// once the stack pointer is inside the red zone, stop descending — the
|
|
/// latched flag makes `stack::run_guarded` discard the walk and defer the
|
|
/// file to wasm. `Default::default()` covers every walker return type in use
|
|
/// (`()`, `bool`, `Option<_>`, `String`); a hook returning `false` just sends
|
|
/// its caller down the generic child walk, whose own guard returns at once.
|
|
macro_rules! stack_guard {
|
|
() => {
|
|
if $crate::stack::exhausted() {
|
|
return ::core::default::Default::default();
|
|
}
|
|
};
|
|
}
|
|
|
|
mod buffers;
|
|
mod ccpp;
|
|
mod cfnptr;
|
|
mod csharp;
|
|
mod dart;
|
|
mod docstring;
|
|
mod ids;
|
|
mod go;
|
|
mod java;
|
|
mod kotlin;
|
|
mod langs;
|
|
mod lua;
|
|
mod php;
|
|
mod rlang;
|
|
mod ruby;
|
|
mod rustlang;
|
|
mod scala;
|
|
mod stack;
|
|
mod swift;
|
|
mod textutil;
|
|
mod python;
|
|
mod tsjs;
|
|
|
|
use napi::bindgen_prelude::*;
|
|
use napi_derive::napi;
|
|
|
|
/// The five flat tables for one file. See buffers.rs for the byte layout;
|
|
/// `src/extraction/kernel/layout.ts` is the TS mirror.
|
|
#[napi(object)]
|
|
pub struct ExtractBuffers {
|
|
pub meta: Buffer,
|
|
pub nodes: Buffer,
|
|
pub edges: Buffer,
|
|
pub refs: Buffer,
|
|
pub arena: Buffer,
|
|
}
|
|
|
|
/// Wire-contract description — the TS loader verifies this against
|
|
/// src/types.ts before routing anything to the kernel, so an out-of-date
|
|
/// `.node` degrades to the wasm path instead of mis-decoding.
|
|
#[napi(object)]
|
|
pub struct ContractInfo {
|
|
pub abi_version: u32,
|
|
pub kernel_version: String,
|
|
pub node_kinds: Vec<String>,
|
|
pub edge_kinds: Vec<String>,
|
|
/// Languages this binary can extract (routing is still TS-side policy).
|
|
pub languages: Vec<String>,
|
|
}
|
|
|
|
/// Grammar identity for the grammar-source-parity gate: the wasm grammar and
|
|
/// the native grammar must expose identical node-kind/field tables, or
|
|
/// kernel-vs-fallback routing would be non-deterministic.
|
|
#[napi(object)]
|
|
pub struct GrammarInfo {
|
|
pub abi_version: u32,
|
|
pub node_kind_count: u32,
|
|
pub field_count: u32,
|
|
pub node_kinds: Vec<String>,
|
|
pub field_names: Vec<String>,
|
|
}
|
|
|
|
#[napi]
|
|
pub fn contract_info() -> ContractInfo {
|
|
ContractInfo {
|
|
abi_version: buffers::KERNEL_ABI_VERSION as u32,
|
|
kernel_version: env!("CARGO_PKG_VERSION").to_string(),
|
|
node_kinds: buffers::NODE_KINDS.iter().map(|s| s.to_string()).collect(),
|
|
edge_kinds: buffers::EDGE_KINDS.iter().map(|s| s.to_string()).collect(),
|
|
languages: langs::LANGUAGES.iter().map(|s| s.to_string()).collect(),
|
|
}
|
|
}
|
|
|
|
#[napi]
|
|
pub fn grammar_info(language: String) -> Option<GrammarInfo> {
|
|
let lang = langs::grammar_for(&language)?;
|
|
let node_kind_count = lang.node_kind_count();
|
|
let field_count = lang.field_count();
|
|
let node_kinds = (0..node_kind_count)
|
|
.map(|i| lang.node_kind_for_id(i as u16).unwrap_or("").to_string())
|
|
.collect();
|
|
// Field ids are 1-based in tree-sitter.
|
|
let field_names = (1..=field_count)
|
|
.map(|i| lang.field_name_for_id(i as u16).unwrap_or("").to_string())
|
|
.collect();
|
|
Some(GrammarInfo {
|
|
abi_version: lang.abi_version() as u32,
|
|
node_kind_count: node_kind_count as u32,
|
|
field_count: field_count as u32,
|
|
node_kinds,
|
|
field_names,
|
|
})
|
|
}
|
|
|
|
/// One struct node's extent for the cFnPtr sweep (mirror of the TS caller's
|
|
/// `{ id, startLine, endLine }`, with `endLine ?? startLine` applied TS-side).
|
|
#[napi(object)]
|
|
pub struct CfnptrStructIn {
|
|
pub id: String,
|
|
pub start_line: u32,
|
|
pub end_line: u32,
|
|
}
|
|
|
|
#[napi(object)]
|
|
pub struct CfnptrFileIn {
|
|
/// RAW file text, exactly as the resolver's readFile returned it.
|
|
pub text: String,
|
|
pub structs: Vec<CfnptrStructIn>,
|
|
}
|
|
|
|
#[napi(object)]
|
|
pub struct CfnptrField {
|
|
pub name: String,
|
|
pub index: u32,
|
|
pub ptr: bool,
|
|
#[napi(js_name = "type")]
|
|
pub ty: String,
|
|
}
|
|
|
|
#[napi(object)]
|
|
pub struct CfnptrStructOut {
|
|
pub id: String,
|
|
pub parsed: bool,
|
|
pub fields: Vec<CfnptrField>,
|
|
}
|
|
|
|
/// The cFnPtr extraction-sweep facts for one file — see cfnptr.rs (and the
|
|
/// TS synthesizer's `FileFacts`) for field semantics.
|
|
#[napi(object)]
|
|
pub struct CfnptrFacts {
|
|
pub fn_ptr_typedefs: Vec<String>,
|
|
pub fn_type_typedefs: Vec<String>,
|
|
pub structs: Vec<CfnptrStructOut>,
|
|
pub inline_ptr: bool,
|
|
pub inline_types: Vec<String>,
|
|
pub inline_tags: Vec<String>,
|
|
pub init_tokens: Vec<String>,
|
|
pub array_elems: Vec<String>,
|
|
pub alias_names: Vec<String>,
|
|
pub d_pairs: Vec<String>,
|
|
pub dispatch_fields: Vec<String>,
|
|
pub array_dispatch_names: Vec<String>,
|
|
pub includes: Vec<String>,
|
|
}
|
|
|
|
/// Batched cFnPtr extraction sweep (task #5 step 2): one call scans a batch
|
|
/// of files and returns their collected facts, amortizing the NAPI boundary.
|
|
/// Feature-detected by the TS loader — absent on older binaries, where the
|
|
/// synthesizer keeps its JS sweep.
|
|
#[napi]
|
|
pub fn cfnptr_scan_files(files: Vec<CfnptrFileIn>) -> Vec<CfnptrFacts> {
|
|
files
|
|
.into_iter()
|
|
.map(|f| {
|
|
let structs: Vec<cfnptr::StructExtent> = f
|
|
.structs
|
|
.into_iter()
|
|
.map(|s| cfnptr::StructExtent { id: s.id, start_line: s.start_line, end_line: s.end_line })
|
|
.collect();
|
|
let facts = cfnptr::scan_file(&f.text, &structs);
|
|
CfnptrFacts {
|
|
fn_ptr_typedefs: facts.fn_ptr_typedefs,
|
|
fn_type_typedefs: facts.fn_type_typedefs,
|
|
structs: facts
|
|
.structs
|
|
.into_iter()
|
|
.map(|s| CfnptrStructOut {
|
|
id: s.id,
|
|
parsed: s.parsed,
|
|
fields: s
|
|
.fields
|
|
.into_iter()
|
|
.map(|fl| CfnptrField { name: fl.name, index: fl.index, ptr: fl.ptr, ty: fl.ty })
|
|
.collect(),
|
|
})
|
|
.collect(),
|
|
inline_ptr: facts.inline_ptr,
|
|
inline_types: facts.inline_types,
|
|
inline_tags: facts.inline_tags,
|
|
init_tokens: facts.init_tokens,
|
|
array_elems: facts.array_elems,
|
|
alias_names: facts.alias_names,
|
|
d_pairs: facts.d_pairs,
|
|
dispatch_fields: facts.dispatch_fields,
|
|
array_dispatch_names: facts.array_dispatch_names,
|
|
includes: facts.includes,
|
|
}
|
|
})
|
|
.collect()
|
|
}
|
|
|
|
/// Debug/differential hook: the native `stripCommentsForRegex(text, 'c')`.
|
|
/// Exists so the strip differential oracle can pin the Rust stripper against
|
|
/// the TS reference directly.
|
|
#[napi]
|
|
pub fn cfnptr_strip_c(text: String) -> String {
|
|
String::from_utf8_lossy(&cfnptr::strip_c(text.as_bytes())).into_owned()
|
|
}
|
|
|
|
#[napi]
|
|
pub fn extract_file(file_path: String, content: String, language: String) -> Result<ExtractBuffers> {
|
|
// The whole walk runs under the stack guard (stack.rs, #1581): a file
|
|
// nested deeply enough to overflow this thread's stack comes back as a
|
|
// `defer:` error — the TS side's routine "take the wasm path" signal —
|
|
// instead of a SIGSEGV that kills the entire indexer process.
|
|
let out = stack::run_guarded(|| match language.as_str() {
|
|
"java" => java::extract(&file_path, &content),
|
|
"python" => python::extract(&file_path, &content),
|
|
"go" => go::extract(&file_path, &content),
|
|
"c" | "cpp" => ccpp::extract(&file_path, &content, &language),
|
|
"rust" => rustlang::extract(&file_path, &content),
|
|
"csharp" => csharp::extract(&file_path, &content),
|
|
"ruby" => ruby::extract(&file_path, &content),
|
|
"php" => php::extract(&file_path, &content),
|
|
"swift" => swift::extract(&file_path, &content),
|
|
"kotlin" => kotlin::extract(&file_path, &content),
|
|
"r" => rlang::extract(&file_path, &content),
|
|
"lua" | "luau" => lua::extract(&file_path, &content, &language),
|
|
"scala" => scala::extract(&file_path, &content),
|
|
"dart" => dart::extract(&file_path, &content),
|
|
_ => tsjs::extract(&file_path, &content, &language),
|
|
})
|
|
.map_err(Error::from_reason)?;
|
|
Ok(ExtractBuffers {
|
|
meta: out.meta.into(),
|
|
nodes: out.nodes.into(),
|
|
edges: out.edges.into(),
|
|
refs: out.refs.into(),
|
|
arena: out.arena.into(),
|
|
})
|
|
}
|