c9f8c0ebaf
An MCP host that kills the launcher chain within the server's first ~100ms while keeping the stdio pipes open (config probe, cancelled request, startup timeout; Rust hosts that kill a child without dropping its stdio handles) left the server orphaned: it booted already reparented to init, so the PPID watchdog's "ppid changed" baseline was captured as 1 and could never fire, and stdin never EOF'd. The process lingered — idle, ~30MB — until the host itself exited, accumulating one per abandoned launch (the pile-up reported in #1185). Reproduced on released 1.2.0/macOS: SIGKILL the launcher at +50ms → permanent orphan; at +150ms the old late baseline had already run and reaped it. Three-part fix: - Capture process.ppid at the earliest line of the CLI entry (early-ppid.ts) and use it as every watchdog baseline, shrinking the blind window to the few ms before our first JS runs. - Thread the real host pid down the bundled path: the npm shim and the standalone sh launcher set CODEGRAPH_HOST_PPID (an outer launcher's value wins), so the watchdog polls the host directly. Previously only the --liftoff-only relaunch set it, leaving the entire npm/standalone install base with hostPpid=null. - Never-initialized backstop (startup-handshake.ts): a serve --mcp that receives no MCP traffic for CODEGRAPH_STARTUP_HANDSHAKE_TIMEOUT_MS (default 15min, 0 disables) shuts down — the catch-all for a kill landing in the residual pre-JS window. Disarmed on the first byte, so a quiet-but-live session is never touched. Also scrub CODEGRAPH_HOST_PPID from the detached daemon's env — it has no host, and a stale pid must not leak into anything it spawns. Validated end-to-end on the built bundle: the +50ms early-kill orphan is now reaped while the host still holds the pipes open, and all six normal lifecycle paths (clean close, SIGTERM/SIGKILL child, host exit/SIGKILL, fd-holding adversarial host) stay clean. New coverage in startup-handshake.test.ts, mcp-startup-orphan.test.ts, and npm-shim.test.ts. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
124 lines
5.0 KiB
Bash
Executable File
124 lines
5.0 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Build a self-contained CodeGraph bundle: an official Node runtime + the
|
|
# compiled app + its production deps, so CodeGraph runs with NO system Node and
|
|
# NO native build — node:sqlite is built into the bundled Node. One archive per
|
|
# platform.
|
|
#
|
|
# Because dropping better-sqlite3 left zero native addons, the recipe is pure
|
|
# file-packaging (download the target's Node, copy the app, archive) — so any
|
|
# platform's bundle can be built on any OS. No cross-compile, no native runners.
|
|
#
|
|
# Usage:
|
|
# scripts/build-bundle.sh <target> [node-version]
|
|
# target: darwin-arm64 | darwin-x64 | linux-x64 | linux-arm64
|
|
# | win32-x64 | win32-arm64
|
|
# node-version: e.g. v24.16.0 (default below; pin for reproducible builds)
|
|
#
|
|
# Output:
|
|
# unix: release/codegraph-<target>.tar.gz (launcher: bin/codegraph)
|
|
# windows: release/codegraph-<target>.zip (launcher: bin/codegraph.cmd)
|
|
set -euo pipefail
|
|
|
|
TARGET="${1:?usage: build-bundle.sh <target> [node-version]}"
|
|
NODE_VERSION="${2:-v24.16.0}"
|
|
|
|
ROOT="$(cd "$(dirname "$0")/.." && pwd)"
|
|
OUT="$ROOT/release"
|
|
WORK="$(mktemp -d)"
|
|
trap 'rm -rf "$WORK"' EXIT
|
|
|
|
ARCH="${TARGET##*-}" # x64 | arm64
|
|
OSFAM="${TARGET%-*}" # darwin | linux | win32
|
|
|
|
echo "[bundle] target=${TARGET} node=${NODE_VERSION}"
|
|
|
|
# 1. Download + extract the official Node runtime for the target platform.
|
|
if [ "$OSFAM" = "win32" ]; then
|
|
NODE_DIST="node-${NODE_VERSION}-win-${ARCH}"
|
|
NODE_URL="https://nodejs.org/dist/${NODE_VERSION}/${NODE_DIST}.zip"
|
|
echo "[bundle] downloading ${NODE_URL}"
|
|
curl -fsSL "$NODE_URL" -o "$WORK/node.zip"
|
|
if command -v unzip >/dev/null 2>&1; then
|
|
unzip -q "$WORK/node.zip" -d "$WORK"
|
|
else
|
|
tar -xf "$WORK/node.zip" -C "$WORK" # bsdtar can read zip
|
|
fi
|
|
NODE_BIN="$WORK/${NODE_DIST}/node.exe"
|
|
else
|
|
NODE_DIST="node-${NODE_VERSION}-${TARGET}"
|
|
NODE_URL="https://nodejs.org/dist/${NODE_VERSION}/${NODE_DIST}.tar.gz"
|
|
echo "[bundle] downloading ${NODE_URL}"
|
|
curl -fsSL "$NODE_URL" -o "$WORK/node.tar.gz"
|
|
tar -xzf "$WORK/node.tar.gz" -C "$WORK"
|
|
NODE_BIN="$WORK/${NODE_DIST}/bin/node"
|
|
fi
|
|
[ -f "$NODE_BIN" ] || { echo "[bundle] error: node binary not found ($NODE_BIN)" >&2; exit 1; }
|
|
|
|
# 2. Build the app (compiled JS + copied wasm/schema assets).
|
|
echo "[bundle] building app"
|
|
( cd "$ROOT" && npm run build >/dev/null )
|
|
|
|
# 3. Stage: app + production-only deps (pure JS/wasm → portable across platforms).
|
|
STAGE="$WORK/codegraph-${TARGET}"
|
|
mkdir -p "$STAGE/lib" "$STAGE/bin"
|
|
cp -R "$ROOT/dist" "$STAGE/lib/dist"
|
|
cp "$ROOT/package.json" "$ROOT/package-lock.json" "$STAGE/lib/"
|
|
echo "[bundle] installing production dependencies"
|
|
( cd "$STAGE/lib" && npm ci --omit=dev --ignore-scripts >/dev/null 2>&1 )
|
|
rm -f "$STAGE/lib/package-lock.json"
|
|
|
|
# 4. Vendored Node + launcher (the launcher uses the bundled Node by relative
|
|
# path, so no system Node is ever needed).
|
|
#
|
|
# `--liftoff-only`: keep tree-sitter's large WASM grammars on V8's Liftoff
|
|
# baseline compiler so they never reach the turboshaft optimizing tier, whose
|
|
# per-compilation Zone arena OOMs the whole process (`Fatal process out of
|
|
# memory: Zone`) on Node >= 22 — even with tens of GB free. The flag is read at
|
|
# V8 engine init so it must be on node's command line; the parse worker inherits
|
|
# it. See issues #293/#298 and src/extraction/wasm-runtime-flags.ts. (The CLI
|
|
# also self-relaunches with this flag when launched without it, so non-bundled
|
|
# runs are covered too; passing it here avoids that extra spawn.)
|
|
if [ "$OSFAM" = "win32" ]; then
|
|
cp "$NODE_BIN" "$STAGE/node.exe"
|
|
printf '@"%%~dp0..\\node.exe" --liftoff-only "%%~dp0..\\lib\\dist\\bin\\codegraph.js" %%*\r\n' \
|
|
> "$STAGE/bin/codegraph.cmd"
|
|
else
|
|
cp "$NODE_BIN" "$STAGE/node"
|
|
cat > "$STAGE/bin/codegraph" <<'LAUNCH'
|
|
#!/bin/sh
|
|
# Resolve symlinks (e.g. the ~/.local/bin/codegraph link install.sh creates) so
|
|
# we find the real bundle dir, not the symlink's location.
|
|
SELF="$0"
|
|
while [ -L "$SELF" ]; do
|
|
target="$(readlink "$SELF")"
|
|
case "$target" in
|
|
/*) SELF="$target" ;;
|
|
*) SELF="$(dirname "$SELF")/$target" ;;
|
|
esac
|
|
done
|
|
DIR="$(cd "$(dirname "$SELF")/.." && pwd)"
|
|
# Thread the MCP host's pid to the server's orphan watchdog (issue #1185).
|
|
# $PPID is our parent — the host itself when it launched this script directly;
|
|
# an already-threaded value (the npm shim sets the true host pid) wins.
|
|
CODEGRAPH_HOST_PPID="${CODEGRAPH_HOST_PPID:-$PPID}"
|
|
export CODEGRAPH_HOST_PPID
|
|
# --liftoff-only: avoid the V8 turboshaft WASM Zone OOM (issues #293/#298).
|
|
exec "$DIR/node" --liftoff-only "$DIR/lib/dist/bin/codegraph.js" "$@"
|
|
LAUNCH
|
|
chmod +x "$STAGE/bin/codegraph"
|
|
fi
|
|
|
|
# 5. Archive (.zip for Windows, .tar.gz otherwise).
|
|
mkdir -p "$OUT"
|
|
if [ "$OSFAM" = "win32" ]; then
|
|
ARCHIVE="$OUT/codegraph-${TARGET}.zip"
|
|
rm -f "$ARCHIVE"
|
|
( cd "$WORK" && zip -rqX "$ARCHIVE" "codegraph-${TARGET}" )
|
|
else
|
|
ARCHIVE="$OUT/codegraph-${TARGET}.tar.gz"
|
|
# --no-xattrs: don't embed macOS xattrs that make GNU tar warn on Linux.
|
|
tar --no-xattrs -czf "$ARCHIVE" -C "$WORK" "codegraph-${TARGET}"
|
|
fi
|
|
echo "[bundle] wrote ${ARCHIVE} ($(du -h "$ARCHIVE" | cut -f1))"
|