2 Commits

Include renames

Author	SHA1	Message	Date
3 people	38eb4e688c	fix(extraction): classify TS/JS class fields by value — properties, not methods (#808) (#809) ... Every TS `public_field_definition` / JS `field_definition` extracted as a method-kind node, so a plain field (`public fonts: Fonts;`) was reported as callable: class shape was misrepresented, kind-based filtering was defeated, and bare-name call resolution landed on data fields — typeorm's boolean `ColumnMetadata::isArray` field was soaking up Array.isArray(...) call edges (685 such wrong edges on typeorm alone). Classification now follows the VALUE (classifyMethodNode hook, mirroring resolveBody's callable detection): arrow-function / function-expression fields and HOF-wrapped ones (`onScroll = throttle(() => {…})`) stay methods with their bodies walked; everything else becomes a property that keeps its type-annotation references edge, visibility, static-ness, and decorators. Field initializers are now walked too (`history = createHistory()` attributes the call to the property — previously invisible), and JS class fields — whose name lives in the grammar's `property` field, so they never extracted a symbol at all — now appear in the graph (resolveName on the JS extractor). With fields correctly kinded, `this.X` callback registration is re-enabled for TS/JS (removed in #807 because field pseudo-methods made it mostly wrong): `this.<member>` candidates resolve CLASS-SCOPED (resolveThisMemberFnRef) — the target must be a function/method sharing the from-symbol's qualified-name class prefix, same file, no fallback — so `addEventListener("online", this.onOfflineStatusToggle)` and API-object wiring (`{ mutateElement: this.mutateElement }`) produce registration edges to the enclosing class's own method, while `this.fonts` (a property) and inherited/unknown members yield no edge. A/B (baseline = #807 main): excalidraw / typeorm / express — node counts identical on all three; kinds shift method→property only (typeorm: exactly 7,406 swapped; excalidraw also corrects 5 anonymous-class mock fields that were function-kind); every one of the 736 dropped call edges targeted a node that is now a property (calls into data fields — verified 100%); gains are retargets to real callables, initializer-call attributions, and +74/+7 class-scoped this.X registration edges (sampled: addEventListener/ removeEventListener wiring, imperative-API method maps). Full suite green (1386). EXTRACTION_VERSION 19 → 20 (re-index to benefit). Closes #808 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-11 14:48:11 -05:00
3 people	8a114ba53c	feat(extraction): capture function-as-value — callback registration sites in callers/impact (#756) (#807) ... A function name used as a VALUE — passed as an argument (signal(SIGINT, handler), qsort(..., compare)), assigned to a function pointer or field (ops->recv_cb = my_cb, OnClick := Handler), or placed in a struct initializer / handler table ({ .recv_cb = my_cb }, { "get", getCommand }) — produced no edge in ANY of the 19 tree-sitter languages, so registered callbacks looked dead and their registration sites were invisible to callers/impact. This adds table-driven function-as-value capture across all 19 languages (plus the wrapper forms: &fn, &Cls::method, Java Class::m, Kotlin ::f, Swift #selector, ObjC @selector, Ruby method(:sym), Scala eta, Pascal @Handler), gated at extraction (same-file definitions + imported bindings; C-family file-scope initializers are constant-expression contexts and skip the gate, which is how redis-style cross-file command tables resolve), and resolved by a dedicated strategy: function/method targets only, same-file first, unique-or-drop cross-file, no fuzzy fallback ever. Edges persist as kind 'references' with metadata.fnRef, so getCallers/getImpactRadius surface them with zero graph-layer changes; MCP callers/callees label them "via callback registration". Precision rules bought by real-repo false positives (full A/B record in docs/design/function-ref-capture.md): C++ is &-explicit outside file-scope tables (fmt's begin/out/size collisions; out-of-line member defs are function-kind); TS/JS/Python bare ids resolve to functions only (TS class fields extract as method-kind — pre-existing quirk); Swift refuses same-file method overload-families; param-forward shapes (this.x = x, value: value) and destructuring are skipped; minified bundles (*.min.js) produce no candidates. Validated on 17 public OSS repos (redis, excalidraw, gin, bytes, okhttp, okio, Alamofire, flask, sinatra, Newtonsoft.Json, scopt, provider, busted, Fusion, AFNetworking, PascalCoin, fmt): node counts identical, zero calls edges lost or gained, references strictly additive (+3,200 registration edges total), precision spot-checked by reading sampled source lines (redis 30/30, flask 8/8). Deliberately NOT covered: indirect-dispatch resolution (o->cb(x) → impl) — that needs data-flow through struct fields, and a wrong edge is worse than none. EXTRACTION_VERSION 18 → 19 (re-index to benefit). Closes #756 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-11 14:20:27 -05:00