fix(extraction): a TS/JS call through a host-global chain emits no ref (#1707) (#1766)

`chrome.storage.local.get(key)` and `document.body.querySelector(s)` end in
a platform API, but the extractor emitted the bare method name for them. That
name then exact-matched whatever project symbol shared it: in a Chrome
extension every `chrome.storage.local.get/set` inside a storage wrapper bound
to the wrapper's own `get`/`set`, giving self-edges that are not in the
source (#1707).

A member chain whose root identifier is a host object the project never
declares now emits nothing — a silent miss instead of a wrong edge, the same
trade the literal-receiver gate makes (#1230). `window` is deliberately not a
host root: `window.MyNs.doThing()` reaches a project symbol. A chain rooted at
a project value keeps the bare name, so `store.getState().act()`, `ref.value
.m()` and `this.<field>.m()` are untouched.

The Rust kernel mirrors the same gate. Verified on Linux: fail→pass on both
kernel and wasm arms for `__tests__/ts-chained-receiver.test.ts` (2 fail / 1
pass on main → 3/3 with the fix).

Lands / rebases https://github.com/colbymchenry/codegraph/pull/1710 onto
current main.

Co-authored-by: Colby McHenry <colbymchenry@users.noreply.github.com>
Co-authored-by: Aaron Queen <bompus@users.noreply.github.com>
This commit is contained in:
Colby Mchenry
2026-09-08 07:47:28 -05:00
committed by GitHub
co-authored by Colby McHenry Aaron Queen
parent 90dcdbc827
commit a7ea5ba730
3 changed files with 176 additions and 0 deletions
+53
View File
@@ -388,6 +388,41 @@ const LITERAL_RECEIVER_TYPES = new Set([
'dictionary', 'dict_literal', 'object', 'tuple', 'set',
]);
/**
* Languages whose member calls go through the TS/JS grammars.
*/
const TS_JS_CHAIN_LANGUAGES = new Set(['typescript', 'tsx', 'javascript', 'jsx']);
/**
* Host objects a TS/JS project never declares: the browser, extension, and
* runtime namespaces, plus the builtin constructors whose statics are library
* calls. A member chain ROOTED at one of these ends in a platform API, so the
* bare method name the extractor used to emit for `chrome.storage.local.get(k)`
* or `document.body.querySelector(s)` could only ever exact-match an unrelated
* project symbol that happened to share the name (#1707). `window` is absent on
* purpose: `window.MyNamespace.doThing()` reaches a project symbol.
*/
const TS_JS_HOST_GLOBAL_ROOTS = new Set([
'chrome', 'browser', 'document', 'navigator', 'performance', 'console',
'localStorage', 'sessionStorage', 'indexedDB', 'crypto', 'globalThis',
'process', 'Math', 'JSON', 'Object', 'Array', 'Reflect', 'Promise', 'Intl',
]);
/** Receiver node types (TS/JS grammars) that continue a member chain downward. */
const TS_JS_CHAIN_RECEIVER_TYPES = new Set(['member_expression', 'subscript_expression']);
/**
* Root identifier of a TS/JS member chain `chrome` for `chrome.storage.local`
* or null when the chain bottoms out in a call, a literal, or `this`.
*/
function tsJsChainRoot(node: SyntaxNode, source: string): string | null {
let cur: SyntaxNode | null = node;
while (cur && TS_JS_CHAIN_RECEIVER_TYPES.has(cur.type)) {
cur = getChildByField(cur, 'object');
}
return cur && cur.type === 'identifier' ? getNodeText(cur, source) : null;
}
/**
* React hooks that bind a NAME to a handler function (`const onPress =
* useCallback(() => {}, [])`). The arrow inside is extracted as a function
@@ -4624,6 +4659,24 @@ export class TreeSitterExtractor {
// Go receivers resolve strictly via validated field-hop
// inference (see matchGoFieldChainCall) or stay unresolved.
calleeName = `${getNodeText(receiver, this.source).replace(/\s+/g, '')}.${methodName}`;
} else if (
TS_JS_CHAIN_LANGUAGES.has(this.language) &&
receiver &&
TS_JS_CHAIN_RECEIVER_TYPES.has(receiver.type) &&
TS_JS_HOST_GLOBAL_ROOTS.has(tsJsChainRoot(receiver, this.source) ?? '')
) {
// TS/JS member call reached through a host namespace —
// `chrome.storage.local.get(key)`, `document.body.querySelector(s)`.
// The bare method name this used to emit exact-matched whatever
// project symbol shared it: every `chrome.storage.local.get/set`
// in a storage wrapper bound to the wrapper's own `get`/`set`,
// a self-edge not in the source (#1707). Emit nothing: a silent
// miss, never a wrong edge. A chain rooted at a project value
// (`window.MyNs.run()`, `store.getState().act()`, `ref.value.m()`)
// keeps the bare name — those targets are real, and dropping them
// would cost far more recall than the mis-bind costs precision.
// Mirrored in the kernel's extract_call (tsjs/extractors.rs).
return;
} else {
calleeName = methodName;
}