feat(resolution): bridge Spring publishEvent() to its @EventListener handlers

Spring decouples an event publisher from its listener(s) through the
application event bus, linked by the event TYPE: publishEvent(new XEvent(...))
has no static edge to the @EventListener void on(XEvent e) that handles it
(usually a different class), so flows dead-end at the publish and the agent
reads to find the handlers. springEventEdges bridges each publishEvent(new X)
site -> every listener of X.

Two-pass, type-keyed (no name resolution, so precision is structural):
- Pass 1 builds Map<eventType, listenerMethod[]> from @EventListener /
  @TransactionalEventListener methods (event type = first param type off the
  node signature, or the @EventListener(X.class) value form) and the older
  `implements ApplicationListener<X>` onApplicationEvent methods.
- Pass 2 links each publishEvent(new XEvent(...))'s enclosing method to every
  listener of XEvent; multi-line `publishEvent(\n new X(...))` handled.

Key Java fact (probed): a method node's range INCLUDES its leading annotations
(startLine is the first @-line, not the `public void` decl), so the annotation
gate scans DOWNWARD from startLine bounded to consecutive @-lines, which can't
bleed into an adjacent method.

Surfaces as `dynamic: spring event` via the generic synth-edge fallback.

Validated 100% precision on two grep-confirmed repos exercising all listener
forms: halo (medium, 1254 java, 33 edges across 24 events, 0 publisher/listener
false positives, param-typed + (X.class) + ApplicationListener + fan-out) and
thombergs/code-examples (4 edges, adds @TransactionalEventListener); 0 on the
gson control (no Spring). Node-stable (pure edge synth). Suite 1617 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Colby McHenry
2026-06-20 22:00:43 -05:00
co-authored by Claude Opus 4.8
parent 6e5c3a9336
commit 9b7ca2e394
4 changed files with 254 additions and 2 deletions
+118 -1
View File
@@ -2186,13 +2186,128 @@ function celeryDispatchEdges(ctx: ResolutionContext): Edge[] {
return edges;
}
// ── Spring application events (Java) ──────────────────────────────────────────
// Spring decouples an event PUBLISHER from its LISTENER(s) through the application
// event bus, linked by the EVENT TYPE (not a name):
// // SomeService.java
// eventPublisher.publishEvent(new PasswordChangedEvent(this, username)); // publish
// // RememberMeTokenRevoker.java — a DIFFERENT file
// @EventListener(PasswordChangedEvent.class) // listen
// public void onPasswordChanged(PasswordChangedEvent event) { ... }
// Bridge it: link the enclosing method at each `publishEvent(new XEvent(...))` site →
// every listener method of XEvent. Listeners are `@EventListener` / `@TransactionalEventListener`
// methods (event type = the first param type, or the `@EventListener(X.class)` value form) and
// the older `class … implements ApplicationListener<X> { void onApplicationEvent(X e) }`. Keyed
// by exact type name, usually cross-file. A repo with no `@EventListener`/`publishEvent` yields 0.
// (Java method nodes INCLUDE their leading annotations in the range — startLine is the first
// `@…` line — so the annotation block is scanned DOWNWARD from startLine, bounded to consecutive
// `@`-lines so it can't bleed into an adjacent method.)
const SPRING_PUBLISH_RE = /\.publishEvent\s*\(\s*new\s+([A-Z][A-Za-z0-9_]*)/g;
const SPRING_LISTENER_ANNO_RE = /@(?:EventListener|TransactionalEventListener)\b/;
const SPRING_ANNO_TYPE_RE = /@(?:EventListener|TransactionalEventListener)\s*\(\s*([A-Z][A-Za-z0-9_]*)\.class/;
const SPRING_APP_LISTENER_RE = /\bApplicationListener\s*</;
const SPRING_JAVA_EXT = /\.java$/;
const SPRING_FANOUT_CAP = 80;
/** The first parameter's type from a Java method `signature` (`"void (XEvent e)"` → `XEvent`).
* Skips a leading `final`/`@Anno`, strips generics, and requires a PascalCase class name (event
* types are classes) — so a no-arg or primitive-param method yields null. */
function springFirstParamType(sig: string | undefined): string | null {
if (!sig) return null;
const open = sig.indexOf('(');
if (open < 0) return null;
const close = sig.indexOf(')', open);
const inner = sig.slice(open + 1, close < 0 ? sig.length : close).trim();
if (!inner) return null;
const first = inner.split(',')[0]!.trim();
const toks = first.split(/\s+/).filter((t) => t && t !== 'final' && !t.startsWith('@'));
if (toks.length < 2) return null; // need `Type name`
const type = toks[toks.length - 2]!.replace(/<.*$/, ''); // drop generic args
return /^[A-Z][A-Za-z0-9_]*$/.test(type) ? type : null;
}
function springEventEdges(ctx: ResolutionContext): Edge[] {
// Pass 1 — event-type → listener methods, scanning only event-relevant files.
const listeners = new Map<string, Node[]>();
for (const file of ctx.getAllFiles()) {
if (!SPRING_JAVA_EXT.test(file)) continue;
const content = ctx.readFile(file);
if (!content) continue;
const hasAnno = content.includes('@EventListener') || content.includes('@TransactionalEventListener');
const hasAppListener = SPRING_APP_LISTENER_RE.test(content);
if (!hasAnno && !hasAppListener) continue;
const lines = content.split('\n');
for (const node of ctx.getNodesInFile(file)) {
if (node.kind !== 'method') continue;
// Collect this method's own leading annotation block (consecutive `@`-lines from startLine).
const annoLines: string[] = [];
for (let i = node.startLine - 1; i < lines.length && i < node.startLine + 7; i++) {
const t = (lines[i] ?? '').trim();
if (!t.startsWith('@')) break; // reached the declaration → stop (no bleed into next method)
annoLines.push(t);
}
const head = annoLines.join('\n');
const annotated = hasAnno && SPRING_LISTENER_ANNO_RE.test(head);
const isAppListener = hasAppListener && node.name === 'onApplicationEvent';
if (!annotated && !isAppListener) continue;
let type = springFirstParamType(node.signature);
if (!type && annotated) {
const m = SPRING_ANNO_TYPE_RE.exec(head);
if (m) type = m[1]!;
}
if (!type) continue;
let arr = listeners.get(type);
if (!arr) { arr = []; listeners.set(type, arr); }
arr.push(node);
}
}
if (!listeners.size) return [];
// Pass 2 — link each publishEvent(new XEvent(...)) site → every listener of XEvent.
const edges: Edge[] = [];
const seen = new Set<string>();
for (const file of ctx.getAllFiles()) {
if (!SPRING_JAVA_EXT.test(file)) continue;
const content = ctx.readFile(file);
if (!content || !content.includes('.publishEvent(')) continue;
const safe = stripCommentsForRegex(content, 'java');
const nodesInFile = ctx.getNodesInFile(file);
SPRING_PUBLISH_RE.lastIndex = 0;
let m: RegExpExecArray | null;
let added = 0;
while ((m = SPRING_PUBLISH_RE.exec(safe)) && added < SPRING_FANOUT_CAP) {
const targets = listeners.get(m[1]!);
if (!targets || !targets.length) continue;
const line = safe.slice(0, m.index).split('\n').length;
const disp = enclosingFn(nodesInFile, line);
if (!disp) continue;
for (const target of targets) {
if (target.id === disp.id) continue;
const key = `${disp.id}>${target.id}`;
if (seen.has(key)) continue;
seen.add(key);
edges.push({
source: disp.id,
target: target.id,
kind: 'calls',
line,
provenance: 'heuristic',
metadata: { synthesizedBy: 'spring-event', via: m[1]!, registeredAt: `${file}:${line}` },
});
added++;
}
}
}
return edges;
}
/**
* Synthesize dispatcher→callback edges (field observers + EventEmitters +
* React re-render + JSX children + Vue templates + SvelteKit load + RN event
* channel + Fabric native-impl + MyBatis Java↔XML + Gin middleware chain +
* Redux-thunk dispatch chain + object-literal registry dispatch + RTK Query
* generated-hook → endpoint + Pinia useStore().action() + Vuex string dispatch +
* Celery task .delay()/.apply_async() → task body).
* Celery task .delay()/.apply_async() → task body + Spring publishEvent → @EventListener).
* Returns the count added. Never throws into indexing — callers wrap in try/catch.
*/
export function synthesizeCallbackEdges(queries: QueryBuilder, ctx: ResolutionContext): number {
@@ -2236,6 +2351,7 @@ export function synthesizeCallbackEdges(queries: QueryBuilder, ctx: ResolutionCo
const piniaEdges = piniaStoreEdges(ctx);
const vuexEdges = vuexDispatchEdges(ctx);
const celeryEdges = celeryDispatchEdges(ctx);
const springEdges = springEventEdges(ctx);
const merged: Edge[] = [];
const seen = new Set<string>();
@@ -2265,6 +2381,7 @@ export function synthesizeCallbackEdges(queries: QueryBuilder, ctx: ResolutionCo
...piniaEdges,
...vuexEdges,
...celeryEdges,
...springEdges,
]) {
const key = `${e.source}>${e.target}`;
if (seen.has(key)) continue;