Apply upstream PR #1623 by danusha2345 (fix commit aa777063), which also addresses #1616, to the current main base. Preserve the upstream WASM and Rust implementations and regression coverage. Index assigned locals, table members, static string keys and nested callback tables as callable symbols, with calls owned by those symbols. Keep dynamic keys unguessed. Add #1650 to the Unreleased changelog and retain the existing re-index guidance without an extraction-version bump. Verified on Linux x64 with Node 22.19.0: - native kernel build, tsc, asset copy, executable CLI - issue repro: 3 nodes / 2 edges -> 4 nodes / 4 edges - EPR.PowerController::SyncHydroPower is indexed; its caller is client.lua - syncHydroPower depth-2 impact reaches client.lua - extraction/resolution/Lua parity: 844 tests passed (kernel expected) - forced-WASM Lua/Luau extraction/resolution: 20 tests passed Co-authored-by: Colby McHenry <colbymchenry@users.noreply.github.com>
This commit is contained in:
co-authored by
Colby McHenry
parent
195888d71f
commit
8c047342cd
@@ -2055,6 +2055,32 @@ func main() {
|
||||
});
|
||||
});
|
||||
|
||||
describe('Lua function-expression resolution (#1616)', () => {
|
||||
it('attributes helper calls to each assigned callable instead of the file node', async () => {
|
||||
fs.writeFileSync(
|
||||
path.join(tempDir, 'util.lua'),
|
||||
`util = {}\nfunction util.helper() return 1 end\nreturn util\n`
|
||||
);
|
||||
fs.writeFileSync(
|
||||
path.join(tempDir, 'handlers.lua'),
|
||||
`local M = {}\nfunction M.namedFn() return util.helper() end\nM.assignedFn = function() return util.helper() end\nM.callbacks = { onStart = function() return util.helper() end }\nreturn M\n`
|
||||
);
|
||||
|
||||
cg = await CodeGraph.init(tempDir, { index: true });
|
||||
cg.resolveReferences();
|
||||
|
||||
const helper = cg
|
||||
.getNodesByKind('method')
|
||||
.find((n) => n.qualifiedName === 'util::helper');
|
||||
expect(helper).toBeDefined();
|
||||
const callers = cg.getCallers(helper!.id).map((c) => c.node);
|
||||
expect(callers.some((n) => n.qualifiedName === 'M::namedFn')).toBe(true);
|
||||
expect(callers.some((n) => n.qualifiedName === 'M::assignedFn')).toBe(true);
|
||||
expect(callers.some((n) => n.qualifiedName === 'M.callbacks::onStart')).toBe(true);
|
||||
expect(callers.some((n) => n.kind === 'file' && n.filePath === 'handlers.lua')).toBe(false);
|
||||
});
|
||||
});
|
||||
|
||||
describe('Watchdog-safe resolution on collision-heavy repos (#1122)', () => {
|
||||
// On a large Java-style repo, per-ref resolution cost is unbounded in the
|
||||
// worst case (a colliding method name whose candidate set misses the LRU
|
||||
|
||||
Reference in New Issue
Block a user