feat: Always enable embeddings, remove enableEmbeddings config option

Testing showed semantic search produces significantly better results for
natural language queries that Claude writes. FTS alone often ranks
properties above their parent classes and misses conceptual matches.
Embeddings are now always on — the vector manager is created eagerly,
with model download and embedding generation still happening lazily.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Colby McHenry
2026-04-03 10:03:41 -05:00
co-authored by Claude Opus 4.6
parent 8b5622d346
commit 7e6914ddff
6 changed files with 10 additions and 29 deletions
-2
View File
@@ -67,7 +67,6 @@ export function validateConfig(config: unknown): config is CodeGraphConfig {
if (typeof c.maxFileSize !== 'number') return false;
if (typeof c.extractDocstrings !== 'boolean') return false;
if (typeof c.trackCallSites !== 'boolean') return false;
if (typeof c.enableEmbeddings !== 'boolean') return false;
// Validate include/exclude are string arrays
if (!c.include.every((p) => typeof p === 'string')) return false;
@@ -128,7 +127,6 @@ function mergeConfig(
maxFileSize: overrides.maxFileSize ?? defaults.maxFileSize,
extractDocstrings: overrides.extractDocstrings ?? defaults.extractDocstrings,
trackCallSites: overrides.trackCallSites ?? defaults.trackCallSites,
enableEmbeddings: overrides.enableEmbeddings ?? defaults.enableEmbeddings,
customPatterns: overrides.customPatterns ?? defaults.customPatterns,
};
}
+3 -6
View File
@@ -157,12 +157,9 @@ export class CodeGraph {
this.resolver = createResolver(projectRoot, queries);
this.graphManager = new GraphQueryManager(queries);
this.traverser = new GraphTraverser(queries);
// Vector manager is created lazily when embeddings are enabled
// Uses global ~/.codegraph/models directory for shared embedding models
if (config.enableEmbeddings) {
this.vectorManager = createVectorManager(db.getDb(), queries, {});
}
// Context builder (uses vector manager if available)
// Vector manager — always created, embeddings generated lazily on first use
this.vectorManager = createVectorManager(db.getDb(), queries, {});
// Context builder (uses vector manager for semantic search)
this.contextBuilder = createContextBuilder(
projectRoot,
queries,
-4
View File
@@ -462,9 +462,6 @@ export interface CodeGraphConfig {
/** Whether to track call sites */
trackCallSites: boolean;
/** Whether to compute embeddings for semantic search */
enableEmbeddings: boolean;
/** Custom symbol patterns to extract */
customPatterns?: {
/** Name for this pattern group */
@@ -675,7 +672,6 @@ export const DEFAULT_CONFIG: CodeGraphConfig = {
maxFileSize: 1024 * 1024, // 1MB
extractDocstrings: true,
trackCallSites: true,
enableEmbeddings: false,
};
// =============================================================================
+3 -12
View File
@@ -236,16 +236,14 @@ ${symbolIndex}`;
// GET /api/embeddings/status
if (pathname === '/api/embeddings/status') {
const config = this.cg.getConfig();
const embeddingStats = this.cg.getEmbeddingStats();
const isEnabled = config.enableEmbeddings === true;
const isInitialized = this.cg.isEmbeddingsInitialized();
const totalVectors = embeddingStats?.totalVectors ?? 0;
const stats = this.cg.getStats();
// Consider ready if we have vectors for at least half the eligible nodes
const eligibleNodes = stats.nodeCount - (stats.nodesByKind.file ?? 0) - (stats.nodesByKind.import ?? 0);
const isReady = isEnabled && totalVectors > 0 && totalVectors >= eligibleNodes * 0.5;
json({ isEnabled, isInitialized, isReady, totalVectors, eligibleNodes });
const isReady = totalVectors > 0 && totalVectors >= eligibleNodes * 0.5;
json({ isEnabled: true, isInitialized, isReady, totalVectors, eligibleNodes });
return;
}
@@ -262,14 +260,7 @@ ${symbolIndex}`;
};
try {
// Step 1: Enable embeddings in config
send('status', { phase: 'config', message: 'Enabling embeddings...' });
const config = this.cg.getConfig();
if (!config.enableEmbeddings) {
this.cg.updateConfig({ enableEmbeddings: true });
}
// Step 2: Initialize embedding model (downloads on first use)
// Step 1: Initialize embedding model (downloads on first use)
send('status', { phase: 'model', message: 'Loading embedding model (first time may download ~30MB)...' });
await this.cg.initializeEmbeddings();
send('status', { phase: 'model', message: 'Embedding model ready' });