github/codegraph
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(resolution): conformance-aware chained-method resolution (#750) (#754)

Browse Source 
* feat(resolution): conformance-aware chained-method resolution (#750)

A chained static-factory/fluent call whose method lives on a SUPERTYPE the
receiver conforms to — a protocol-extension method (Swift), an interface default
method, or an inherited superclass method — now resolves. resolveMethodOnType
falls back to walking the return type's implements/extends edges (via the new
context.getSupertypes) when the method isn't a direct member. Because those edges
don't exist during the single-pass resolution, a second pass
(resolveChainedCallsViaConformance) re-resolves the deferred chained refs after
edges are built. Still validated, so a wrong inference yields no edge.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs(changelog): conformance-aware chained-method resolution (#750)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Colby Mchenry
2026-06-09 01:38:37 -04:00
committed by GitHub
co-authored by Claude Opus 4.8
parent aa07dc59d4
commit 48d4654e8d
7 changed files with 196 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/resolution/name-matcher.ts
+20 -1
View File
@@ -267,6 +267,8 @@ function resolveMethodOnType(
* signal Java imports carry but the call site doesn't (#314).
*/
preferredFqn?: string,
/** Recursion guard for the supertype/conformance walk. */
depth = 0,
): ResolvedRef | null {
// Look up methods by name and match by qualifiedName ending in
// `<typeName>::<methodName>`. This works whether the method is defined
@@ -284,7 +286,24 @@ function resolveMethodOnType(
matches.push(m);
}
}
if (matches.length === 0) return null;
if (matches.length === 0) {
// Conformance fallback: the method may be defined on a supertype `typeName`
// extends, or on a protocol / trait it conforms to (e.g. a Swift protocol-
// extension method, a C# default-interface or extension method, a Kotlin
// extension on a supertype). Walk supertypes transitively (depth-capped) via
// the resolved implements/extends edges — empty in the first resolution pass,
// populated in the conformance pass. Still VALIDATED (the method must exist on
// a supertype), so a wrong inference produces no edge.
if (depth < 4 && context.getSupertypes) {
for (const supertype of context.getSupertypes(typeName, ref.language)) {
const via = resolveMethodOnType(
supertype, methodName, ref, context, confidence, resolvedBy, preferredFqn, depth + 1,
);
if (via) return via;
}
}
return null;
}
if (matches.length > 1 && preferredFqn) {
const ext = ref.language === 'kotlin' ? '.kt' : '.java';