fix(explore): accurately resolve query file paths and find camelCase symbols

Previously, `codegraph_explore` queries explicitly naming files by path (e.g., `src/routes/m/projects/[id]/runs/[runId]/+page.svelte`) were shredded. Bracketed path segments exploded into "named symbol" seeds, and FTS on fragments like `page` or `runs` admitted every sibling file, starving the user's intended target. This change introduces: - **Query path pinning:** File paths named in a query are now resolved against the index, "pinned," and stripped from the query. Pinned files are guaranteed inclusion, top ranking, and fair allocation. Unresolvable path-like spans are reported. - **Segment vocabulary supplement:** Natural language query terms (e.g., "auto-scroll to bottom") can now reach camelCase identifiers (e.g., `pinFeedIfNearBottom`, `feedAtBottom`) by matching against their constituent segments. - **Variable seeding:** `variable` and `constant` node kinds are now included in identifier seeding, improving recall for `$state`-style variables common in frameworks like Svelte.
2026-08-20 09:10:07 -07:00
parent c6aaa20358
commit 238dbc5cec
15 changed files with 905 additions and 31 deletions
@@ -0,0 +1,129 @@
+/**
+ * File-path recognition in explore queries (src/search/query-paths.ts).
+ *
+ * The originating bug: an agent named two SvelteKit route files by exact path
+ * (`src/routes/m/projects/[id]/runs/[runId]/+page.svelte`) and the explore
+ * pipeline shredded them — the seeding tokenizer splits on brackets, so the
+ * fragments `runId`/`scope` seeded as "named symbols" and headlined the blast
+ * radius, while FTS admitted every sibling `+page.svelte` off the `page`/`runs`
+ * fragments. These tests pin the module that stops that: path spans resolve
+ * against the indexed file list, matching files pin, and the spans leave the
+ * query. Resolution IS the detector — slash-bearing non-paths stay untouched.
+ */
+import { describe, it, expect } from 'vitest';
+import { extractQueryPaths, queryMightContainPaths } from '../src/search/query-paths';
+
+const INDEX = [
+  'src/routes/m/projects/[id]/runs/[runId]/+page.svelte',
+  'src/routes/m/projects/[id]/chat/[scope]/+page.svelte',
+  'src/routes/m/projects/[id]/+page.svelte',
+  'src/routes/(protected)/chat-window/+page.svelte',
+  'src/lib/chat-manager.ts',
+  'src/lib/task-runner-manager.ts',
+  'src/lib/stores/sqlite-store.ts',
+  'src/lib/stores/postgresql-store.ts',
+];
+
+describe('queryMightContainPaths — the cheap pre-gate', () => {
+  it('fires on slashes and dotted basenames', () => {
+    expect(queryMightContainPaths('look at src/lib/chat-manager.ts')).toBe(true);
+    expect(queryMightContainPaths('look at chat-manager.ts please')).toBe(true);
+  });
+
+  it('stays quiet on plain prose and Class.method spans', () => {
+    expect(queryMightContainPaths('how does the scroll pinning work')).toBe(false);
+    // `.isPackaged` is 10 chars — past the 8-char extension cap.
+    expect(queryMightContainPaths('what reads app.isPackaged here')).toBe(false);
+  });
+});
+
+describe('extractQueryPaths — resolution and stripping', () => {
+  it('resolves a bracketed SvelteKit path and strips it from the query', () => {
+    const q = 'auto-scroll logic in src/routes/m/projects/[id]/runs/[runId]/+page.svelte — atBottom tracking';
+    const out = extractQueryPaths(q, INDEX);
+    expect(out.pinnedFiles).toEqual(['src/routes/m/projects/[id]/runs/[runId]/+page.svelte']);
+    expect(out.strippedQuery).not.toContain('+page.svelte');
+    expect(out.strippedQuery).not.toContain('runId');
+    expect(out.strippedQuery).toContain('atBottom tracking');
+    expect(out.unresolvedPathSpans).toEqual([]);
+  });
+
+  it('pins multiple named files in appearance order', () => {
+    const q = 'compare src/routes/m/projects/[id]/chat/[scope]/+page.svelte and src/routes/m/projects/[id]/runs/[runId]/+page.svelte';
+    const out = extractQueryPaths(q, INDEX);
+    expect(out.pinnedFiles).toEqual([
+      'src/routes/m/projects/[id]/chat/[scope]/+page.svelte',
+      'src/routes/m/projects/[id]/runs/[runId]/+page.svelte',
+    ]);
+  });
+
+  it('resolves a (protected) route-group path — parens are path characters', () => {
+    const out = extractQueryPaths('read src/routes/(protected)/chat-window/+page.svelte', INDEX);
+    expect(out.pinnedFiles).toEqual(['src/routes/(protected)/chat-window/+page.svelte']);
+  });
+
+  it('resolves an absolute path by walking suffixes to the indexed relative path', () => {
+    const q = 'fix /Users/colby/dev/beads-live-dashboard/src/lib/chat-manager.ts';
+    const out = extractQueryPaths(q, INDEX);
+    expect(out.pinnedFiles).toEqual(['src/lib/chat-manager.ts']);
+  });
+
+  it('resolves a unique basename and a partial path', () => {
+    expect(extractQueryPaths('see chat-manager.ts', INDEX).pinnedFiles)
+      .toEqual(['src/lib/chat-manager.ts']);
+    expect(extractQueryPaths('see stores/sqlite-store.ts', INDEX).pinnedFiles)
+      .toEqual(['src/lib/stores/sqlite-store.ts']);
+  });
+
+  it('strips wrapping punctuation and line references', () => {
+    const out = extractQueryPaths('the bug (see `src/lib/chat-manager.ts:243`).', INDEX);
+    expect(out.pinnedFiles).toEqual(['src/lib/chat-manager.ts']);
+    const hash = extractQueryPaths('regression at src/lib/task-runner-manager.ts#L88-L120', INDEX);
+    expect(hash.pinnedFiles).toEqual(['src/lib/task-runner-manager.ts']);
+  });
+
+  it('treats an over-ambiguous basename as unresolved — stripped and reported', () => {
+    const out = extractQueryPaths('why do all +page.svelte files flash', INDEX);
+    expect(out.pinnedFiles).toEqual([]);
+    expect(out.unresolvedPathSpans).toEqual(['+page.svelte']);
+    expect(out.strippedQuery).toBe('why do all files flash');
+  });
+
+  it('strips and reports a clearly-path-shaped span that matches nothing', () => {
+    const out = extractQueryPaths('crash in src/routes/gone/missing-page.svelte on load', INDEX);
+    expect(out.pinnedFiles).toEqual([]);
+    expect(out.unresolvedPathSpans).toEqual(['src/routes/gone/missing-page.svelte']);
+    expect(out.strippedQuery).toBe('crash in on load');
+  });
+
+  it('leaves slash-bearing non-paths alone', () => {
+    const q = 'does gen_server:call/2 block and/or timeout';
+    const out = extractQueryPaths(q, INDEX);
+    expect(out.pinnedFiles).toEqual([]);
+    expect(out.unresolvedPathSpans).toEqual([]);
+    expect(out.strippedQuery).toBe(q);
+  });
+
+  it('dedupes a path named twice and honors maxPins', () => {
+    const twice = extractQueryPaths(
+      'src/lib/chat-manager.ts wraps src/lib/chat-manager.ts', INDEX,
+    );
+    expect(twice.pinnedFiles).toEqual(['src/lib/chat-manager.ts']);
+
+    const capped = extractQueryPaths(
+      'src/lib/chat-manager.ts src/lib/task-runner-manager.ts', INDEX, { maxPins: 1 },
+    );
+    expect(capped.pinnedFiles).toEqual(['src/lib/chat-manager.ts']);
+  });
+
+  it('matches case-insensitively but returns the indexed spelling', () => {
+    const out = extractQueryPaths('SRC/LIB/CHAT-MANAGER.TS', INDEX);
+    expect(out.pinnedFiles).toEqual(['src/lib/chat-manager.ts']);
+  });
+
+  it('passes through untouched when nothing resolves', () => {
+    const q = 'plain prose question about scrolling';
+    const out = extractQueryPaths(q, INDEX);
+    expect(out).toEqual({ strippedQuery: q, pinnedFiles: [], unresolvedPathSpans: [] });
+  });
+});