A NestJS-style monorepo has one UserService/UserModule/UserRepository per app; with no package concept for TS they share one global name scope and agents visibly warned that CodeGraph was mixing unrelated classes. Two distinct problems, two fixes: 1. TOOL AGGREGATION. callers/callees returned one merged list across every same-named match, and impact merged all their blast radii into a single overstated subgraph. Now: matches group into DISTINCT DEFINITIONS (filePath + qualifiedName — same-file overloads still merge, that's the overload feature) and render one file-labeled section per definition; a new `file` argument (path or suffix, like codegraph_node's) narrows to one definition, suppressing the stale aggregation note; a non-matching `file` falls back to all definitions with a note. server-instructions documents the behavior. 2. RESOLUTION WRONG EDGES. Auditing a real monorepo (amplication, 54k nodes) found 1,036 cross-package `references` edges into duplicated names. Root cause: the React framework resolver ran PascalCase component resolution on refs from PLAIN .ts FILES (a GraphQL types file's own `Account` type alias lost to an arbitrary same-named CLASS in another package — the resolver's blind `components[0]` fallback at confidence 0.8 outranked the name-matcher's proximity-correct 0.7). Component resolution is now gated to JSX-capable refs (tsx/jsx) and never guesses among multiple candidates without a positional signal (same-dir / component-dir / unique). Cross-package wrong edges: 1,036 -> 40 (-96%; the remainder are genuine shared-model imports and codegen template scaffolds), with the freed refs re-resolving to the correct same-file/same-package targets. excalidraw (a real React repo) is a zero-delta control — legitimate component refs all carry same-dir/component-dir signals. Graph-level separation was verified correct on a fixture before any changes (import + proximity resolution keeps apps apart) — the conflation was tool-level plus the react-resolver edge class. Tests: 6-test e2e suite (grouped callers/callees, per-definition impact radii, file narrowing, fallback note, cross-app edge isolation) + react resolver unit tests updated to production reality (tsx refs resolve, plain-ts refs decline). Full suite 1398 passed. EXTRACTION_VERSION 23 -> 24 (re-index to drop the wrong cross-package edges). Closes #764 Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
dce61a5f4a
commit
222af6b87c
@@ -581,12 +581,23 @@ from ..services import auth_service
|
||||
line: 10,
|
||||
column: 5,
|
||||
filePath: 'src/App.tsx',
|
||||
language: 'typescript' as const,
|
||||
// Refs extracted from .tsx files carry language 'tsx' — component
|
||||
// resolution is gated to JSX-capable refs (#764: PascalCase TYPE refs
|
||||
// from plain .ts files were resolving to arbitrary same-named classes).
|
||||
language: 'tsx' as const,
|
||||
};
|
||||
|
||||
const result = reactResolver!.resolve(ref, context);
|
||||
expect(result).not.toBeNull();
|
||||
expect(result?.targetNodeId).toBe('component:src/Button.tsx:Button:5');
|
||||
|
||||
// The same PascalCase name referenced from a plain .ts file is a TYPE
|
||||
// reference, not a component usage — component resolution must decline
|
||||
// and leave it to proximity-aware name matching (#764: a .ts GraphQL
|
||||
// types file's own `Account` alias was losing to an arbitrary same-named
|
||||
// class in another monorepo package).
|
||||
const tsRef = { ...ref, filePath: 'src/models.ts', language: 'typescript' as const };
|
||||
expect(reactResolver!.resolve(tsRef, context)).toBeNull();
|
||||
});
|
||||
|
||||
it('should resolve custom hook references', () => {
|
||||
|
||||
Reference in New Issue
Block a user